Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TruePeak Interpolator: Ensure enough storage #284

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

weefuzzy
Copy link
Member

fixes #283

Introduce a min upsampling factor to ensure that maximum delay can be anticipated at construction time (would be better, actually, if SR were passed to TruePeak at construction time, but one thing at a time).

Introduce a min upsampling factor to ensure that maximum delay can be anticipated at construction time (would be better, actually, if SR were passed to TruePeak at construction time)
@weefuzzy weefuzzy added the bug Something isn't working label Oct 27, 2024
@weefuzzy weefuzzy requested a review from tremblap October 27, 2024 00:25
@weefuzzy weefuzzy self-assigned this Oct 27, 2024
Copy link
Member

@tremblap tremblap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran the UTs - results as expected

@weefuzzy weefuzzy merged commit bf9038b into flucoma:main Oct 31, 2024
3 checks passed
@weefuzzy weefuzzy deleted the fix/interpolator_overrun branch October 31, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: Interpolator doesn't allocate enough memory at higher SRs
2 participants