-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpinLock to guard NRT cache #11
Conversation
It is my first PR on GitHub, I don't see how I can pull to test it... help! |
This could be clearer: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally short version is that you can checkout a read-only version of the PR branch like
(assuming you've called your Github remote 'origin') So, in this case,e.g
|
I'm trying to setup SourceTree to behave as well as it does with BitBucket and show them... not easy. if I run the first line you sent, I get it in the gui and then I can check it out there... maybe I could se pull as subtree in there. |
adding |
it works! - ok now to the thing at hand. |
It worked on Mac, now compiling Windows and Linux in parallel on two native machines... |
Linux - it works thrice in a row, more than 3 times faster than on Mac despite having half the cores and being 10 times older! |
on Windows, it works perfectly too. It does not solve the problem of 13-massive parallelisation on Linux, is that expected? |
It is. I think that problem is due to us making it possible to spawn an absurd number of threads all at once, which is a Bad Idea in general. |
so I should merge and accept pull request? |
Be my guest |
An attempt to address #10 which I hope @tremblap will be kind enough to road test for me