Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpinLock to guard NRT cache #11

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

weefuzzy
Copy link
Member

@weefuzzy weefuzzy commented May 5, 2021

An attempt to address #10 which I hope @tremblap will be kind enough to road test for me

@weefuzzy weefuzzy requested a review from tremblap May 5, 2021 15:40
@tremblap
Copy link
Member

tremblap commented May 6, 2021

It is my first PR on GitHub, I don't see how I can pull to test it... help!

@weefuzzy
Copy link
Member Author

weefuzzy commented May 6, 2021

This could be clearer: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally

short version is that you can checkout a read-only version of the PR branch like

git fetch origin pull/<pull request id>/head:<local branch name, whatever you want>

(assuming you've called your Github remote 'origin') So, in this case,e.g

git fetch origin pull/11/head:sc-thread-crash
git checkout sc-thread-crash

@tremblap
Copy link
Member

tremblap commented May 6, 2021

I'm trying to setup SourceTree to behave as well as it does with BitBucket and show them... not easy. if I run the first line you sent, I get it in the gui and then I can check it out there... maybe I could se pull as subtree in there.

@tremblap
Copy link
Member

tremblap commented May 6, 2021

https://stackoverflow.com/questions/38815839/how-to-checkout-a-forked-pull-request-locally-in-sourcetree

adding
fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
will help - stay tuned :)

@tremblap
Copy link
Member

tremblap commented May 6, 2021

it works! - ok now to the thing at hand.

@tremblap
Copy link
Member

tremblap commented May 6, 2021

It worked on Mac, now compiling Windows and Linux in parallel on two native machines...

@tremblap
Copy link
Member

tremblap commented May 6, 2021

Linux - it works thrice in a row, more than 3 times faster than on Mac despite having half the cores and being 10 times older!

@tremblap
Copy link
Member

tremblap commented May 6, 2021

on Windows, it works perfectly too. It does not solve the problem of 13-massive parallelisation on Linux, is that expected?

@weefuzzy
Copy link
Member Author

weefuzzy commented May 6, 2021

It is. I think that problem is due to us making it possible to spawn an absurd number of threads all at once, which is a Bad Idea in general.

@tremblap
Copy link
Member

tremblap commented May 6, 2021

so I should merge and accept pull request?

@weefuzzy
Copy link
Member Author

weefuzzy commented May 6, 2021

Be my guest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux: batch processing crashes the server after a few thousand instances
2 participants