Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Various Learn Enhancements #213

Closed
wants to merge 7 commits into from
Closed

[Enhancement] Various Learn Enhancements #213

wants to merge 7 commits into from

Conversation

jdchart
Copy link
Collaborator

@jdchart jdchart commented Feb 11, 2022

This is going to be the PR that implements the general changes discussed in these issues:

#199
#200
#201
#190

Not ready to merge yet but will be soon.

@jdchart jdchart added the enhancement New feature or request label Feb 11, 2022
@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flucoma/learn/26jyhuuk86YvALNS2qxUTadZ3gMZ
✅ Preview: https://learn-git-front-page-flucoma.vercel.app

@jdchart
Copy link
Collaborator Author

jdchart commented Feb 11, 2022

First, #201 , @tremblap I have simply added a link at the top of made-with directing towards a full catalogue of pieces made with the tools: https://learn-git-front-page-flucoma.vercel.app/madewithflucoma

is this sufficient or do you want an entry under made-with?

And i suppose we must therefore remove the articles concerning the 2 gigs, even if i think it's a shame. I can link in the same manner, or again, make an article that directs people to all the different types of content on the www.

@jdchart
Copy link
Collaborator Author

jdchart commented Feb 11, 2022

Also, having not heard anything more on #199 , i will action this as learn/explore/reference this afternoon, which won 2/2 votes!

the implementation of this is a complete nightmare and needs to be redone, this is a sketch to start formulating ideas.
@jdchart
Copy link
Collaborator Author

jdchart commented Feb 11, 2022

Started working on a new homepage layout which i think will be better at showing what the site has to offer - although the implementation of it is a complete shit-show. Just prototyping ideas.

@tremblap
Copy link
Member

@jdchart I love this stream of consciousness PR and I take for granted you will ping us for review when ready? r.e. #201 I couldn't find the item, and r.e. #199 I am not enamoured by the words but cannot find something better. the order change is also a good call.

@jamesb93
Copy link
Member

I would appreciate no one elses merges this till I have taken a look. Changing the names is more complicated than changing them on the surface of the HTML.

Also #190 is redundant now.

@jamesb93
Copy link
Member

jamesb93 commented Feb 13, 2022

In fact, let's not address #199 or #200 at all in this PR and do it separately. Much cleaner that way. If you wanna experiment make a local branch.

@jamesb93
Copy link
Member

I like the vibe of the rework of the front page but it needs some work to make it polished. Let's hack on it together sometime this week.

@jamesb93
Copy link
Member

I've opened a new PR for #199 here #218

@jdchart
Copy link
Collaborator Author

jdchart commented Feb 14, 2022

Yep, will ping when need input, and good call to move #199 to #218 @jamesb93 .

Indeed I was wanting to look at the front page stuff with you James, this was just to get an idea. Notably accessing the global layout css - I'd perhaps like things to be wider, less margin. And we can discuss how we would want to feature things - at the moment its just random on each page load. And perhaps talk about being able to define a featured image for each page so that there's potentially more eye-catching things on the front page. But i do like this layout where we can see more of everything at the same time (without it being chaotic).

@jdchart
Copy link
Collaborator Author

jdchart commented Feb 14, 2022

@tremblap for #201 , let me be more clear:

for the moment, I've just added a line of text and a link at the top of the made with flucoma page that points towards the www. learn catalogue of pieces.

is this sufficient, or do you want a full 'article' in the made with flucoma section that deals with this, and perhaps also other things that are on www like the gigs?

Also, there are two full entries in made with that deal with the gigs, but of course there's overlap with what's on the www website (even if I find the learn entries to be more complete). For the sake of not havign duplicates do you want me to remove these entries?

@jamesb93
Copy link
Member

Yep, will ping when need input, and good call to move #199 to #218 @jamesb93 .

Indeed I was wanting to look at the front page stuff with you James, this was just to get an idea. Notably accessing the global layout css - I'd perhaps like things to be wider, less margin. And we can discuss how we would want to feature things - at the moment its just random on each page load. And perhaps talk about being able to define a featured image for each page so that there's potentially more eye-catching things on the front page. But i do like this layout where we can see more of everything at the same time (without it being chaotic).

I agree with all of this :) Wider, pictures that get gobbled up as a preview. Let's talk about it more when you have some brainspace.

@jamesb93 jamesb93 closed this May 23, 2022
@jamesb93 jamesb93 deleted the front-page branch May 23, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants