RDI-2056 #52
Open
RDI-2056 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gst.wasm/subprojects/gst-plugins-web/gst/web/gstwebdownload.cpp
Outdated
Show resolved
Hide resolved
gst.wasm/subprojects/gst-plugins-web/gst/web/gstwebdownload.cpp
Outdated
Show resolved
Hide resolved
aslobodeniuk
requested changes
Oct 22, 2024
turran
requested changes
Oct 22, 2024
gst.wasm/subprojects/gst-plugins-web/gst/web/gstwebdownload.cpp
Outdated
Show resolved
Hide resolved
turran
reviewed
Oct 24, 2024
gst.wasm/subprojects/gst-plugins-web/gst/web/gstwebdownload.cpp
Outdated
Show resolved
Hide resolved
turran
requested changes
Oct 28, 2024
| @@ -37,6 +38,9 @@ gboolean gst_web_utils_element_handle_context_query ( | |||
| GstElement *element, GstQuery *query, GstWebCanvas *canvas); | |||
| gboolean gst_web_utils_element_set_context ( | |||
| GstElement *element, GstContext *context, GstWebCanvas **canvas); | |||
| GstVideoFormat gst_web_utils_convert_video_frame_format ( | |||
There was a problem hiding this comment.
Try to use the "namespace" of the object first after utlils, instead of the verb. For example, gst_web_utils_video_format_from_web_format, or gst_web_utils_video_format_from_string, etc.
There was a problem hiding this comment.
@cfoch This isnt solved yet.
CC: @aslobodeniuk
There was a problem hiding this comment.
I only fixed the specific line, but now I have fixed the line below, too.
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebvideoframe.cpp
Outdated
Show resolved
Hide resolved
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebvideoframe.cpp
Outdated
Show resolved
Hide resolved
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebvideoframe.cpp
Show resolved
Hide resolved
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebvideoframe.cpp
Outdated
Show resolved
Hide resolved
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebvideoframe.cpp
Outdated
Show resolved
Hide resolved
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebutils.c
Outdated
Show resolved
Hide resolved
aslobodeniuk
approved these changes
Nov 4, 2024
aslobodeniuk
requested changes
Nov 4, 2024
| init_pipeline () | ||
| { | ||
| pipeline = | ||
| gst_parse_launch ("webfetchsrc location=" DEFAULT_URL " ! " |
There was a problem hiding this comment.
webstreamsrc have been merged, and I would say it should be preferred to webfetchsrc, because it downloads the data in a smoother way. Without a queue in the pipeline the playback will be more smooth.
aslobodeniuk
approved these changes
Nov 4, 2024
cfoch
force-pushed
the
RDI-2056
branch
2 times, most recently
from
2d1d8ce
to
34dcb85
Compare
aslobodeniuk
reviewed
Nov 5, 2024
gst.wasm/subprojects/gst-plugins-web/gst-libs/gst/web/gstwebvideoframe.cpp
Outdated
Show resolved
Hide resolved
aslobodeniuk
approved these changes
Nov 5, 2024
Ref #RDI-2056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.