Detect hardware accelerated codec and use the correct scale filter #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-ilin
reviewed
Jan 23, 2023
| @@ -6,17 +6,35 @@ | |||
| */ | |||
|
|
|||
|
|
|||
| function getScaleFilter(output) { | |||
| if (output.video.get('-vcodec').length > 1) { | |||
| let codec = output.video.get('-vcodec')[1]; | |||
There was a problem hiding this comment.
Such condition would not work in case of the video codec option is not the first one in the list.
The following approach works correct:
if (!!output.video.find('-vcodec', 1)) {
let codec = output.video.find('-vcodec', 1)[0];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware accelerated codec use specific
scalefilters thussize()does not generate working video filters.This PR detects some hardware accelerated video codecs and uses the correct
scalefilter.Closes #1120