Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_kinesis_streams: Add Port config option for Kinesis plugin #9171

Conversation

Athishpranav2003
Copy link

@Athishpranav2003 Athishpranav2003 commented Aug 6, 2024

Add option to configure port for Kinesis plugin

Addresses #9160
Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@Athishpranav2003
Copy link
Author

@PettitWesley Can you please check this PR

@Athishpranav2003
Copy link
Author

@cosmo0920 seems like @PettitWesley is inactive for a while. Is it possible if this PR can be reassigned?

@Athishpranav2003
Copy link
Author

@ashie seems like no one is responding to this PR. Could you please help me get this checked with the right person :)

@cosmo0920
Copy link
Contributor

@ashie seems like no one is responding to this PR. Could you please help me get this checked with the right person :)

Hey, he is a head of Fluentd development team but he is not active for Fluent Bit, I'm afraid.

@cosmo0920
Copy link
Contributor

Could you add a documentation PR for corresponding this?
Documentation repo is here: https://github.com/fluent/fluent-bit-docs

@Athishpranav2003
Copy link
Author

@cosmo0920 it's already done and got approved fluent/fluent-bit-docs#1421

I didn't know he is not part of Fluent-bit :(

@Athishpranav2003
Copy link
Author

@cosmo0920 any updates on this?

@Athishpranav2003
Copy link
Author

@cosmo0920 ping for review

@Athishpranav2003
Copy link
Author

@edsiper ping for review

plugins/out_kinesis_streams/kinesis.c Outdated Show resolved Hide resolved
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding test cases and port number assertions would be good to have.

@Athishpranav2003
Copy link
Author

Athishpranav2003 commented Sep 2, 2024

@cosmo0920 i guess we cant access the member variables here so asserting port number seems not possible. Is there any wrapper that exposes these internal struct variables? I couldnt see similar tests in other runtime tests

For now i have added the port configuration too in the UT

Signed-off-by: Athish Pranav D <[email protected]>
@cosmo0920
Copy link
Contributor

cosmo0920 commented Sep 2, 2024

Athishpranav2003 commented 2 hours ago
@cosmo0920 i guess we cant access the member variables here so asserting port number seems not possible. Is there any wrapper that exposes these internal struct variables? I couldnt see similar tests in other runtime tests

For now i have added the port configuration too in the UT

We can use flb_lib mechanism for testing with configs.
Unfortunately, #9317 would be good because this PR has associated unit tests and port range assertion. So, I’ll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants