Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_splunk: Extend retrying HTTP status code #9375

Merged

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Sep 11, 2024

408 and 429 also should be treated as retry.

Related to #9371.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@meehanman
Copy link

This should be 429 and not 428.

429

You've made too many requests

Splunk Secure Gateway cannot handle that many requests at a time. Lower your number of requests and try again.

--

Additionally I'll try and ping some of the Splunk contributors for their opinion.

408 and 429 also should be treated as retry.

Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920
Copy link
Contributor Author

This should be 429 and not 428.

429

You've made too many requests

Splunk Secure Gateway cannot handle that many requests at a time. Lower your number of requests and try again.

Oh, sorry. I made a mistake. I fixed it.

@edsiper edsiper merged commit 41b90b7 into master Sep 16, 2024
46 checks passed
@edsiper edsiper deleted the cosmo0920-extend-retry-http-status-codes-on-out_splunk branch September 16, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants