Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply PR#468 patch only for 0.12.x. #513

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Apply PR#468 patch only for 0.12.x. #513

merged 1 commit into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. Apply PR#468 patch only for 0.12.x. 

    With fluent#468,
 rdkafka 0.12.0 specific patch (Rdkafka::Producer::Client) was
introduced [1], but rdkafka's internal change was reverted [2]
(removed Rdkafka::Producer::Client) later in 0.13.x.

[1] karafka/rdkafka-ruby#172
[2] karafka/rdkafka-ruby#211

So this monkey patch should be effective only between 0.12.0 and
0.12.1 (only 2 versions were shipped in 0.12.x).
For 0.13.x or later, it seems harmful.

Signed-off-by: Kentaro Hayashi <[email protected]>
    @kenhys
    kenhys committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c7c35d0 View commit details
    Browse the repository at this point in the history