Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not to load WinevtXMLparser by default #108

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Not to load WinevtXMLparser by default #108

merged 1 commit into from
Aug 1, 2024

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jun 7, 2024

WinevtXMLparser is not a mandatory dependency.
We need it only when enabling render_as_xml.

So, this plugin should not load it by default.
It can cause unintended NotFoundPluginError.

{datetime} [error]: config error file="xxx" error_class=Fluent::NotFoundPluginError
error="Unknown parser plugin 'winevt_xml'. Run 'gem search -rd fluent-plugin' to find plugins"

@daipom
Not to load WinevtXMLparser by default
ba86519 
WinevtXMLparser is not a mandatory dependency.
We need it only when enabling `render_as_xml`.

So, this plugin should not load it by default.
It can cause unintended NotFoundPluginError.

Signed-off-by: Daijiro Fukuda <[email protected]>
@cosmo0920 cosmo0920 merged commit 7be478d into master Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daipom @cosmo0920