-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delimiter and Casing options for parsing #113
Merged
ashie
merged 11 commits into
fluent:master
from
BlakeHensleyy:delimiter-options-for-parsing-fixed
Aug 2, 2024
Merged
Add Delimiter and Casing options for parsing #113
ashie
merged 11 commits into
fluent:master
from
BlakeHensleyy:delimiter-options-for-parsing-fixed
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
`key=` not needed Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Blake Hensley <[email protected]>
prefix_word to key Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
daipom
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
ashie
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the options description_prefix_word_delimiter, description_word_delimiter, and downcase_description_keys. The inclusion of these options will make it possible to align the key naming scheme with the rest of an organizations logs.
(This pr is replacing #112. The updates to CHANGLOG and README were made by mistake and can be ignored.)
Related issue:
Note: This PR fixes the issue partially. To fix the issue completely, we need to take
Data Name
ofEventData
.)