Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): #1069 update commitlint #1112

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

sebas031811
Copy link
Contributor

No description provided.

@dsalaza4
Copy link
Contributor

dsalaza4 commented Jun 21, 2023

Hi @sebas031811,

First of all, thank you so much for your contribution!

  1. You need to update the lockfile by using the makeNodeJsLock builtin for lintGitCommitMsg to actually use a newer commitlint version.
  2. Please specify in the commit and PR bodies: Upgrade from X to Y

@dsalaza4
Copy link
Contributor

Hi @sebas031811,

First of all, thank you so much for your contribution!

  1. You need to update the lockfile by using the makeNodeJsLock builtin for lintGitCommitMsg to actually use a newer commitlint version.
  2. Please specify in the commit and PR bodies: Upgraded from X to Y

Oh NVM I just saw the lockfile was updated too!

@dsalaza4
Copy link
Contributor

You're referencing issue #0, please specify a valid issue.

@dsalaza4
Copy link
Contributor

Hi @sebas031811,
First of all, thank you so much for your contribution!

  1. You need to update the lockfile by using the makeNodeJsLock builtin for lintGitCommitMsg to actually use a newer commitlint version.
  2. Please specify in the commit and PR bodies: Upgraded from X to Y

Oh NVM I just saw the lockfile was updated too!

Did you update the lockfile using the makeNodeJsLock builtin? If not please do so.

@dsalaza4
Copy link
Contributor

/lintGitMailMap not passing. Please read https://makes.fluidattacks.com/contributing/

@sebas031811 sebas031811 changed the title feat(build): #0 update commitlint feat(build): #1069 update commitlint Jun 21, 2023
@sebas031811
Copy link
Contributor Author

Hello @dsalaza4, thanks for your feedback!
/lintGitMailMap runs OK in local, did you mean /lintGitCommitMsg ?

@dsalaza4
Copy link
Contributor

Hello @dsalaza4, thanks for your feedback!
/lintGitMailMap runs OK in local, did you mean /lintGitCommitMsg ?

It looks like you need to add another entry: https://github.com/fluidattacks/makes/actions/runs/5337582823/jobs/9674088936?pr=1112

Upgrade from 16.2.4 to 17.6.5

Signed-off-by: Sebastian Cardona <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dsalaza4
Copy link
Contributor

LGTM!

@dsalaza4 dsalaza4 merged commit 78993b5 into fluidattacks:main Jun 21, 2023
38 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants