feat(build): #834 npm registry tokens #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dacevedo12
commented
Jul 14, 2023
dacevedo12
commented
- allow passing tokens for private registries
dacevedo12
commented
Jul 14, 2023
dsalaza4
reviewed
Jul 14, 2023
|
any chance this can be deployed to ghcr to test it in the CI or would a local test suffice? |
dacevedo12
force-pushed
the
main
branch
2 times, most recently
from
117c107
to
27ca6ae
Compare
|
@dacevedo12 For this specific case, making it work locally should be enough |
- allow passing tokens for private registries Signed-off-by: David Acevedo <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Couldn't find a way to safely pass secrets to be used at build time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.