FIX: #1246 handle empty params on confirmPayment #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remonh87
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Sorry it was an extremely busy months. Thanks for picking up the issue. @jonasbark can you double check the android side?
jonasbark
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been over a month since reporting the #1246 issue, and I'm running out of time to deliver a feature dependant on this fix, so I decided to have a go at trying to fix it myself. The details of why the
confirmPaymentmethod should handle null this way, are described in my issue description. I have next to none prior experience with Swift or Kotlin, so please double check that my changes don't break any other use cases.