-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PayPal payments #1341
Fix PayPal payments #1341
Conversation
@JonasWanke thanks for the pr. Can you run |
Hi @remonh87, I just ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
thanks for the fix! any timeline for when it will be published on pub.dev? |
Any timeline on publishing a new version with this MR would be appreciated. Thanks in advance! |
Any update on this? |
Fixes: #1211
The serialization of
MandateDataCustomerAcceptance
was incorrect: In Stripe's API, it corresponds to a sealed union representing anonline
or anoffline
mandate. In Stripe's Android SDK, it's modelled the same way, though onlyonline
is supported. To maintain backwards compatibility, I kept the existing class structure and only added customfromJson(…)
andtoJson(…)
implementations, though a cleaner design would probably be a named constructorMandateDataCustomerAcceptance.online(…)
.The other problem was that
PaymentMethodType
was missing a PayPal variant, meaning the native SDK's result message couldn't be parsed.Now, payment and setup intents for subscriptions in Stripe are working for us both on Android and iOS with the following parameters: