Fix android payment sheet shapes not rendering correct when using double type #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'double' value type was creating issues with Android's rendering when tried to change payment sheet appearance. Using integer values is fixing this issue. That is of course a breaking change and needs to be discussed carefully. Also added missing 'borderRadius' support for "PaymentSheetPrimaryButtonShape" class as this is already supported by both of the sdk's as well as in the stripe-react-native implementation.
volkanakbayir
changed the title
volkanakbayir
changed the title
|
Thanks for the PR! The double -> int change is not necessary. Would you mind updating your PR and change the ReadableMap.java class from: throw new Exception("We've got a double here");to: return (int) getDouble(key); |
jonasbark
added a commit
that referenced
this pull request
Sep 28, 2024
|
Done in #1942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'double' value type was not affecting the android side of rendering and creating inconsistent UI among Android's and iOS's UI rendering when tried to change payment sheet appearance. Using integer values is fixing this issue for android to actually abide this. iOS can also use the integer values as well.
That is of course a breaking change and needs to be discussed carefully. There maybe a better solution for this to handle it properly elsewhere like the platform code themselves? I see the code is copied from stripe-react-native I didn't want to touch that part.
Also added missing 'borderRadius' support for "PaymentSheetPrimaryButtonShape" class as this is already supported by both of the sdk's as well as in the stripe-react-native implementation.