Skip to content

Commit

Permalink
Fusion presubmits should specify a realm property (#4089)
Browse files Browse the repository at this point in the history
LUCI recipes should set an environment variable to this property if it exists; the Flutter Tool should set the `engine.realm` file as appropriate.
  • Loading branch information
jtmcdole authored Dec 13, 2024
1 parent bfb9cb1 commit 2daa915
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app_dart/lib/src/service/luci_build_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,9 @@ class LuciBuildService {

if (isFusion) {
properties['is_fusion'] = 'true';
// When in fusion, we want the recipies to override the engine.realm
// if some environment variable (FLUTTER_REALM) is set.
properties['flutter_realm'] = 'flutter_archives_v2';
}

final List<bbv2.RequestedDimension> requestedDimensions = target.getDimensions();
Expand Down
2 changes: 2 additions & 0 deletions app_dart/test/service/luci_build_service_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ void main() {
'exe_cipd_version': bbv2.Value(stringValue: 'refs/heads/main'),
'recipe': bbv2.Value(stringValue: 'devicelab/devicelab'),
'is_fusion': bbv2.Value(stringValue: 'true'),
'flutter_realm': bbv2.Value(stringValue: 'flutter_archives_v2'),
});
expect(dimensions.length, 1);
expect(dimensions[0].key, 'os');
Expand Down Expand Up @@ -508,6 +509,7 @@ void main() {
'exe_cipd_version': bbv2.Value(stringValue: 'refs/heads/main'),
'recipe': bbv2.Value(stringValue: 'devicelab/devicelab'),
'is_fusion': bbv2.Value(stringValue: 'true'),
'flutter_realm': bbv2.Value(stringValue: 'flutter_archives_v2'),
});
expect(dimensions.length, 1);
expect(dimensions[0].key, 'os');
Expand Down

0 comments on commit 2daa915

Please sign in to comment.