Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log pull request for autosubmit triage #1988

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

keyonghan
Copy link
Contributor

Follow up of #1987

@@ -53,15 +53,15 @@ class CheckPullRequest extends AuthenticatedRequestHandler {
final String messageData = message.message!.data!;
final rawBody = json.decode(String.fromCharCodes(base64.decode(messageData))) as Map<String, dynamic>;
final PullRequest pullRequest = PullRequest.fromJson(rawBody);
log.info('Processing PR: $pullRequest');
log.info('Processing PR: $rawBody');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably go through the github library and add toString methods to these objects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue from github repo: SpinlockLabs/github.dart#323

Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 18, 2022
@auto-submit auto-submit bot merged commit 7e4d967 into flutter:main Jul 18, 2022
@keyonghan keyonghan deleted the logging_followup branch March 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants