review comments

flutter · Jul 17, 2023 · 7136c05 · 7136c05
1 parent 3c61d45
commit 7136c05
Show file tree

Hide file tree

Showing 67 changed files with 91 additions and 92 deletions.
diff --git a/packages/devtools_app/lib/devtools_app.dart b/packages/devtools_app/lib/devtools_app.dart
@@ -3,8 +3,6 @@
 // found in the LICENSE file.
 
 export 'src/app.dart';
-export 'src/extensions/static/extension_points_base.dart';
-export 'src/extensions/static/extension_points_external.dart';
 export 'src/framework/app_bar.dart';
 export 'src/framework/home_screen.dart';
 export 'src/framework/notifications_view.dart';
@@ -77,6 +75,8 @@ export 'src/shared/console/primitives/simple_items.dart';
 export 'src/shared/console/widgets/description.dart';
 export 'src/shared/diagnostics/diagnostics_node.dart';
 export 'src/shared/diagnostics/inspector_service.dart';
+export 'src/shared/environment_parameters/environment_parameters_base.dart';
+export 'src/shared/environment_parameters/environment_parameters_external.dart';
 export 'src/shared/error_badge_manager.dart';
 export 'src/shared/globals.dart';
 export 'src/shared/http/http_request_data.dart';

diff --git a/packages/devtools_app/lib/main.dart b/packages/devtools_app/lib/main.dart
@@ -5,8 +5,8 @@
 import 'package:flutter/foundation.dart';
 
 import 'initialization.dart';
-import 'src/extensions/static/extension_points_base.dart';
-import 'src/extensions/static/extension_points_external.dart';
+import 'src/shared/environment_parameters/environment_parameters_base.dart';
+import 'src/shared/environment_parameters/environment_parameters_external.dart';
 import 'src/shared/globals.dart';
 import 'src/shared/primitives/utils.dart';
 
@@ -26,7 +26,7 @@ void externalRunDevTools({
   List<DevToolsJsonFile> sampleData = const [],
 }) {
   // Set the extension points global.
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
 
   runDevTools(
     integrationTestMode: integrationTestMode,

diff --git a/packages/devtools_app/lib/src/extensions/README.md b/packages/devtools_app/lib/src/extensions/README.md
@@ -0,0 +1,6 @@
+## What are DevTools extensions?
+
+DevTools extensions are custom tooling screens provided by pub packages that
+can be loaded into DevTools at runtime.
+
+This feature is under construction - more documenation to come.
diff --git a/packages/devtools_app/lib/src/extensions/runtime/README.md b/packages/devtools_app/lib/src/extensions/runtime/README.md
diff --git a/packages/devtools_app/lib/src/extensions/static/README.md b/packages/devtools_app/lib/src/extensions/static/README.md
diff --git a/...ensions/static/extension_points_base.dart → ...rameters/environment_parameters_base.dart b/...ensions/static/extension_points_base.dart → ...rameters/environment_parameters_base.dart
@@ -3,10 +3,10 @@
 // found in the LICENSE file.
 
 import '../../screens/debugger/codeview.dart';
-import '../../shared/common_widgets.dart';
-import '../../shared/diagnostics/inspector_service.dart';
+import '../common_widgets.dart';
+import '../diagnostics/inspector_service.dart';
 
-abstract class DevToolsExtensionPoints {
+abstract class DevToolsEnvironmentParameters {
   List<ScriptPopupMenuOption> buildExtraDebuggerScriptPopupMenuOptions();
 
   Link issueTrackerLink({String? additionalInfo, String? issueTitle});

diff --git a/...ons/static/extension_points_external.dart → ...ters/environment_parameters_external.dart b/...ons/static/extension_points_external.dart → ...ters/environment_parameters_external.dart
@@ -5,14 +5,15 @@
 import 'package:flutter/foundation.dart';
 
 import '../../screens/debugger/codeview.dart';
-import '../../shared/analytics/constants.dart' as gac;
-import '../../shared/common_widgets.dart';
-import '../../shared/diagnostics/inspector_service.dart';
-import '../../shared/globals.dart';
-import '../../shared/utils.dart';
-import 'extension_points_base.dart';
-
-class ExternalDevToolsExtensionPoints implements DevToolsExtensionPoints {
+import '../analytics/constants.dart' as gac;
+import '../common_widgets.dart';
+import '../diagnostics/inspector_service.dart';
+import '../globals.dart';
+import '../utils.dart';
+import 'environment_parameters_base.dart';
+
+class ExternalDevToolsEnvironmentParameters
+    implements DevToolsEnvironmentParameters {
   @override
   List<ScriptPopupMenuOption> buildExtraDebuggerScriptPopupMenuOptions() =>
       <ScriptPopupMenuOption>[];

diff --git a/packages/devtools_app/lib/src/shared/globals.dart b/packages/devtools_app/lib/src/shared/globals.dart
@@ -2,13 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import '../extensions/static/extension_points_base.dart';
 import '../screens/debugger/breakpoint_manager.dart';
 import '../service/service_manager.dart';
 import '../shared/banner_messages.dart';
 import '../shared/notifications.dart';
 import 'config_specific/ide_theme/ide_theme.dart';
 import 'console/eval/eval_service.dart';
+import 'environment_parameters/environment_parameters_base.dart';
 import 'framework_controller.dart';
 import 'offline_mode.dart';
 import 'preferences.dart';
@@ -41,8 +41,8 @@ SurveyService get surveyService => globals[SurveyService] as SurveyService;
 PreferencesController get preferences =>
     globals[PreferencesController] as PreferencesController;
 
-DevToolsExtensionPoints get devToolsExtensionPoints =>
-    globals[DevToolsExtensionPoints] as DevToolsExtensionPoints;
+DevToolsEnvironmentParameters get devToolsExtensionPoints =>
+    globals[DevToolsEnvironmentParameters] as DevToolsEnvironmentParameters;
 
 OfflineModeController get offlineController =>
     globals[OfflineModeController] as OfflineModeController;

diff --git a/packages/devtools_app/test/app_size/app_size_screen_test.dart b/packages/devtools_app/test/app_size/app_size_screen_test.dart
@@ -24,7 +24,7 @@ import '../test_infra/test_data/app_size/unsupported_file.dart';
 void main() {
   setUp(() {
     setGlobal(ServiceConnectionManager, FakeServiceManager());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(NotificationService, NotificationService());

diff --git a/packages/devtools_app/test/app_size/code_size_attribution_test.dart b/packages/devtools_app/test/app_size/code_size_attribution_test.dart
@@ -18,7 +18,7 @@ void main() {
 
   setUp(() {
     setGlobal(ServiceConnectionManager, FakeServiceManager());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     setGlobal(IdeTheme, IdeTheme());
     callGraph = generateCallGraphWithDominators(

diff --git a/packages/devtools_app/test/cpu_profiler/cpu_profiler_controller_test.dart b/packages/devtools_app/test/cpu_profiler/cpu_profiler_controller_test.dart
@@ -37,7 +37,7 @@ void main() {
     }
 
     setUp(() {
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(ServiceConnectionManager, fakeServiceManager);
       setGlobal(OfflineModeController, OfflineModeController());
       setGlobal(PreferencesController, PreferencesController());

diff --git a/packages/devtools_app/test/cpu_profiler/cpu_profiler_test.dart b/packages/devtools_app/test/cpu_profiler/cpu_profiler_test.dart
@@ -47,7 +47,7 @@ void main() {
       processId: 'test',
     );
 
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(OfflineModeController, OfflineModeController());
     setGlobal(NotificationService, NotificationService());
     setGlobal(BannerMessagesController, BannerMessagesController());

diff --git a/packages/devtools_app/test/cpu_profiler/profiler_screen_controller_test.dart b/packages/devtools_app/test/cpu_profiler/profiler_screen_controller_test.dart
@@ -14,7 +14,7 @@ void main() {
     when(fakeServiceManager.connectedApp!.isFlutterAppNow).thenReturn(false);
 
     setUp(() {
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(ServiceConnectionManager, fakeServiceManager);
       setGlobal(OfflineModeController, OfflineModeController());
       setGlobal(PreferencesController, PreferencesController());

diff --git a/packages/devtools_app/test/debugger/debugger_codeview_statistics_test.dart b/packages/devtools_app/test/debugger/debugger_codeview_statistics_test.dart
@@ -41,7 +41,7 @@ void main() {
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(ScriptManager, MockScriptManager());
     setGlobal(NotificationService, NotificationService());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     scriptsHistory.pushEntry(mockScript!);
     final mockCodeViewController = debuggerController.codeViewController;

diff --git a/packages/devtools_app/test/debugger/debugger_codeview_test.dart b/packages/devtools_app/test/debugger/debugger_codeview_test.dart
@@ -45,7 +45,7 @@ void main() {
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(ScriptManager, MockScriptManager());
     setGlobal(NotificationService, NotificationService());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     fakeServiceManager.consoleService.ensureServiceInitialized();
     when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_console_test.dart b/packages/devtools_app/test/debugger/debugger_console_test.dart
@@ -26,7 +26,7 @@ void main() {
   setGlobal(ScriptManager, MockScriptManager());
   setGlobal(NotificationService, NotificationService());
   setGlobal(EvalService, MockEvalService());
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
   setGlobal(PreferencesController, PreferencesController());
   fakeServiceManager.consoleService.ensureServiceInitialized();
   when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_evaluation_test.dart b/packages/devtools_app/test/debugger/debugger_evaluation_test.dart
@@ -26,7 +26,7 @@ void main() {
   late EvalOnDartLibrary eval;
 
   setUp(() async {
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(BreakpointManager, BreakpointManager());
     setGlobal(EvalService, EvalService());
     setGlobal(NotificationService, NotificationService());

diff --git a/packages/devtools_app/test/debugger/debugger_screen_breakpoints_test.dart b/packages/devtools_app/test/debugger/debugger_screen_breakpoints_test.dart
@@ -27,7 +27,7 @@ void main() {
   setGlobal(ScriptManager, scriptManager);
   setGlobal(NotificationService, NotificationService());
   setGlobal(BreakpointManager, mockBreakpointManager);
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
   setGlobal(PreferencesController, PreferencesController());
   fakeServiceManager.consoleService.ensureServiceInitialized();
   when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_screen_call_stack_test.dart b/packages/devtools_app/test/debugger/debugger_screen_call_stack_test.dart
@@ -32,7 +32,7 @@ void main() {
     setGlobal(NotificationService, NotificationService());
     setGlobal(BreakpointManager, BreakpointManager());
     setGlobal(ScriptManager, scriptManager);
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     fakeServiceManager.consoleService.ensureServiceInitialized();
     when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_screen_explorer_hidden_test.dart b/packages/devtools_app/test/debugger/debugger_screen_explorer_hidden_test.dart
@@ -24,7 +24,7 @@ void main() {
   setGlobal(ScriptManager, scriptManager);
   setGlobal(NotificationService, NotificationService());
   setGlobal(BreakpointManager, BreakpointManager());
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
   setGlobal(PreferencesController, PreferencesController());
   fakeServiceManager.consoleService.ensureServiceInitialized();
   when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_screen_explorer_visible_test.dart b/packages/devtools_app/test/debugger/debugger_screen_explorer_visible_test.dart
@@ -25,7 +25,7 @@ void main() {
   setGlobal(NotificationService, NotificationService());
   setGlobal(ScriptManager, scriptManager);
   setGlobal(BreakpointManager, BreakpointManager());
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
   setGlobal(PreferencesController, PreferencesController());
   fakeServiceManager.consoleService.ensureServiceInitialized();
   when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_screen_paused_test.dart b/packages/devtools_app/test/debugger/debugger_screen_paused_test.dart
@@ -33,7 +33,7 @@ void main() {
   setGlobal(ScriptManager, scriptManager);
   setGlobal(NotificationService, NotificationService());
   setGlobal(BreakpointManager, BreakpointManager());
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
   setGlobal(PreferencesController, PreferencesController());
   fakeServiceManager.consoleService.ensureServiceInitialized();
   when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_screen_test.dart b/packages/devtools_app/test/debugger/debugger_screen_test.dart
@@ -44,7 +44,7 @@ void main() {
     setGlobal(NotificationService, NotificationService());
     setGlobal(BreakpointManager, BreakpointManager());
     setGlobal(EvalService, MockEvalService());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     fakeServiceManager.consoleService.ensureServiceInitialized();
     when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_screen_variables_test.dart b/packages/devtools_app/test/debugger/debugger_screen_variables_test.dart
@@ -33,7 +33,7 @@ void main() {
     setGlobal(ScriptManager, scriptManager);
     setGlobal(NotificationService, NotificationService());
     setGlobal(BreakpointManager, BreakpointManager());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     fakeServiceManager.consoleService.ensureServiceInitialized();
     when(fakeServiceManager.errorBadgeManager.errorCountNotifier('debugger'))

diff --git a/packages/devtools_app/test/debugger/debugger_scripts_test.dart b/packages/devtools_app/test/debugger/debugger_scripts_test.dart
@@ -27,7 +27,7 @@ void main() {
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(ScriptManager, MockScriptManager());
     setGlobal(NotificationService, NotificationService());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
 
     mockConnectedApp(

diff --git a/packages/devtools_app/test/debugger/program_explorer_test.dart b/packages/devtools_app/test/debugger/program_explorer_test.dart
@@ -32,7 +32,7 @@ void main() {
           createMockProgramExplorerControllerWithDefaults();
       setGlobal(IdeTheme, IdeTheme());
       setGlobal(ServiceConnectionManager, fakeServiceManager);
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(PreferencesController, PreferencesController());
     });
 

diff --git a/packages/devtools_app/test/extentsion_points/extensions_external_test.dart b/packages/devtools_app/test/extentsion_points/extensions_external_test.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'package:devtools_app/src/extensions/static/extension_points_external.dart';
+import 'package:devtools_app/src/shared/environment_parameters/environment_parameters_external.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 void main() {

diff --git a/packages/devtools_app/test/inspector/diagnostics_test.dart b/packages/devtools_app/test/inspector/diagnostics_test.dart
@@ -45,7 +45,7 @@ void main() {
       ''',
     );
     setUp(() {
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(PreferencesController, PreferencesController());
       setGlobal(IdeTheme, IdeTheme());
       setGlobal(ServiceConnectionManager, FakeServiceManager());

diff --git a/packages/devtools_app/test/inspector/inspector_integration_test.dart b/packages/devtools_app/test/inspector/inspector_integration_test.dart
@@ -45,7 +45,7 @@ void main() async {
     }
   };
 
-  setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+  setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
   setGlobal(BreakpointManager, BreakpointManager());
   setGlobal(IdeTheme, IdeTheme());
   setGlobal(NotificationService, NotificationService());

diff --git a/packages/devtools_app/test/inspector/inspector_screen_test.dart b/packages/devtools_app/test/inspector/inspector_screen_test.dart
@@ -48,7 +48,7 @@ void main() {
     when(fakeServiceManager.errorBadgeManager.errorCountNotifier('inspector'))
         .thenReturn(ValueNotifier<int>(0));
 
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(ServiceConnectionManager, fakeServiceManager);
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(PreferencesController, PreferencesController());

diff --git a/packages/devtools_app/test/inspector/inspector_tree_test.dart b/packages/devtools_app/test/inspector/inspector_tree_test.dart
@@ -21,7 +21,7 @@ void main() {
     when(app.isFlutterAppNow).thenReturn(true);
     when(app.isProfileBuildNow).thenReturn(false);
 
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(ServiceConnectionManager, fakeServiceManager);
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(PreferencesController, PreferencesController());

diff --git a/packages/devtools_app/test/logging/logging_screen_data_test.dart b/packages/devtools_app/test/logging/logging_screen_data_test.dart
@@ -36,7 +36,7 @@ void main() {
         .thenReturn(ValueNotifier<int>(0));
     setGlobal(ServiceConnectionManager, fakeServiceManager);
     setGlobal(NotificationService, NotificationService());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     setGlobal(IdeTheme, IdeTheme());
   });

diff --git a/packages/devtools_app/test/logging/logging_screen_test.dart b/packages/devtools_app/test/logging/logging_screen_test.dart
@@ -39,7 +39,7 @@ void main() {
       when(fakeServiceManager.errorBadgeManager.errorCountNotifier('logging'))
           .thenReturn(ValueNotifier<int>(0));
       setGlobal(NotificationService, NotificationService());
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(PreferencesController, PreferencesController());
       setGlobal(ServiceConnectionManager, fakeServiceManager);
       setGlobal(IdeTheme, IdeTheme());

diff --git a/packages/devtools_app/test/memory/memory_screen_test.dart b/packages/devtools_app/test/memory/memory_screen_test.dart
@@ -39,7 +39,7 @@ void main() {
         .thenReturn(false);
     when(fakeServiceManager.connectedApp!.isDartWebApp)
         .thenAnswer((_) => Future.value(false));
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(ServiceConnectionManager, fakeServiceManager);
     setGlobal(PreferencesController, PreferencesController());
     setGlobal(OfflineModeController, OfflineModeController());

diff --git a/packages/devtools_app/test/network/network_profiler_test.dart b/packages/devtools_app/test/network/network_profiler_test.dart
@@ -48,7 +48,7 @@ void main() {
     socketProfile = loadSocketProfile();
     httpProfile = loadHttpProfile();
     setGlobal(IdeTheme, IdeTheme());
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(PreferencesController, PreferencesController());
     setGlobal(NotificationService, NotificationService());
     setGlobal(BreakpointManager, BreakpointManager());

diff --git a/packages/devtools_app/test/network/network_request_inspector_test.dart b/packages/devtools_app/test/network/network_request_inspector_test.dart
@@ -25,7 +25,7 @@ void main() {
 
     setUp(() {
       setGlobal(IdeTheme, IdeTheme());
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(PreferencesController, PreferencesController());
       clipboardContents = '';
       fakeServiceManager = FakeServiceManager(

diff --git a/packages/devtools_app/test/performance/controls/performance_controls_test.dart b/packages/devtools_app/test/performance/controls/performance_controls_test.dart
@@ -13,7 +13,7 @@ void main() {
   const windowSize = Size(3000.0, 1000.0);
 
   setUp(() {
-    setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+    setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
     setGlobal(IdeTheme, IdeTheme());
     setGlobal(PreferencesController, PreferencesController());
     setGlobal(OfflineModeController, OfflineModeController());

diff --git a/packages/devtools_app/test/performance/flutter_frames/flutter_frames_chart_test.dart b/packages/devtools_app/test/performance/flutter_frames/flutter_frames_chart_test.dart
@@ -45,7 +45,7 @@ void main() {
       setGlobal(IdeTheme, IdeTheme());
       setGlobal(NotificationService, NotificationService());
       setGlobal(BannerMessagesController, BannerMessagesController());
-      setGlobal(DevToolsExtensionPoints, ExternalDevToolsExtensionPoints());
+      setGlobal(DevToolsEnvironmentParameters, ExternalDevToolsEnvironmentParameters());
       setGlobal(PreferencesController, PreferencesController());
 
       framesController = FlutterFramesController(