called getFullRequestData() before export (#8333)

flutter · Sep 30, 2024 · 89e6c7e · 89e6c7e
1 parent 11bb202
commit 89e6c7e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/devtools_app/lib/src/screens/network/network_controller.dart b/packages/devtools_app/lib/src/screens/network/network_controller.dart
@@ -61,7 +61,8 @@ class NetworkController extends DisposableController
   }
   List<DartIOHttpRequestData>? _httpRequests;
 
-  String? exportAsHarFile() {
+  Future<String?> exportAsHarFile() async {
+    await _fetchFullDataBeforeExport();
     _httpRequests =
         filteredData.value.whereType<DartIOHttpRequestData>().toList();
 
@@ -386,6 +387,12 @@ class NetworkController extends DisposableController
       serviceConnection.errorBadgeManager.incrementBadgeCount(NetworkScreen.id);
     }
   }
+
+  Future<void> _fetchFullDataBeforeExport() => Future.wait(
+        filteredData.value
+            .whereType<DartIOHttpRequestData>()
+            .map((item) => item.getFullRequestData()),
+      );
 }
 
 /// Class for managing the set of all current sockets, and

diff --git a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
@@ -41,7 +41,7 @@ TODO: Remove this section if there are not any general updates.
 
 ## Network profiler updates
 
-TODO: Remove this section if there are not any general updates.
+* Resolved an issue in .har export where response content was sometimes missing in the data. - [#8333](https://github.com/flutter/devtools/pull/8333)
 
 ## Logging updates