review comments

flutter · Sep 1, 2023 · 9d6ba59 · 9d6ba59
1 parent 3c53357
commit 9d6ba59
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/devtools_shared/CHANGELOG.md b/packages/devtools_shared/CHANGELOG.md
@@ -1,10 +1,11 @@
 # 4.0.0
 
 - Bump `package:extension_discovery` version to ^2.0.0
-- Adds a `DeeplinkApi.androidBuildVariants` endpoint to ServerAPi.
+- Adds a `DeeplinkApi.androidBuildVariants` endpoint to ServerApi.
 - **BREAKING CHANGE**:
-  - ServerApi.handle extensionsManager, api parameter are converted to named parameters
-  - Adds a new required name parameter deeplinkManager to `ServerApi.handle`.
+  - `ServerApi.handle` parameters `extensionsManager` and `api` were converted to named
+    parameters
+  - Adds a new required named parameter `deeplinkManager` to `ServerApi.handle`.
 
 # 3.0.1
 

diff --git a/packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart b/packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart
@@ -51,7 +51,6 @@ class DeeplinkManager {
       };
     }
     return <String, String?>{
-      kErrorField: null,
       kOutputJsonField: outputJson,
     };
   }

diff --git a/packages/devtools_shared/lib/src/server/server_api.dart b/packages/devtools_shared/lib/src/server/server_api.dart
@@ -396,7 +396,8 @@ abstract class _DeeplinkApiHandler {
     if (error != null) {
       api.serverError(error);
     }
-    return api
-        .getCompleted(result[DeeplinkManager.kOutputJsonField]! as String);
+    return api.getCompleted(
+      result[DeeplinkManager.kOutputJsonField]! as String,
+    );
   }
 }