Remove the legacy Provider screen now that this is shipped as a DevTo…

…ols extension (#8364)
flutter · Oct 1, 2024 · b554737 · b554737
1 parent 899eb59
commit b554737
Show file tree

Hide file tree

Showing 37 changed files with 59 additions and 7,800 deletions.
diff --git a/packages/devtools_app/lib/initialization.dart b/packages/devtools_app/lib/initialization.dart
@@ -4,14 +4,12 @@
 
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/material.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:flutter_web_plugins/url_strategy.dart';
 
 import 'src/app.dart';
 import 'src/framework/app_error_handling.dart';
 import 'src/framework/framework_core.dart';
 import 'src/screens/debugger/syntax_highlighter.dart';
-import 'src/screens/provider/riverpod_error_logger_observer.dart';
 import 'src/shared/analytics/analytics_controller.dart';
 import 'src/shared/config_specific/logger/logger_helpers.dart';
 import 'src/shared/feature_flags.dart';
@@ -43,12 +41,9 @@ void runDevTools({
 
     // Run the app.
     runApp(
-      ProviderScope(
-        observers: const [ErrorLoggerObserver()],
-        child: DevToolsApp(
-          screens ?? defaultScreens(sampleData: sampleData),
-          await analyticsController,
-        ),
+      DevToolsApp(
+        screens ?? defaultScreens(sampleData: sampleData),
+        await analyticsController,
       ),
     );
   });

diff --git a/packages/devtools_app/lib/src/app.dart b/packages/devtools_app/lib/src/app.dart
@@ -304,9 +304,9 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
             scaffold = DevToolsScaffold.withChild(
               embedMode: embedMode,
               child: CenteredMessage(
-                'No DevTools '
-                '${queryParams.hideAllExceptExtensions ? 'extensions' : 'screens'} '
-                'available for your project.',
+                message: 'No DevTools '
+                    '${queryParams.hideAllExceptExtensions ? 'extensions' : 'screens'} '
+                    'available for your project.',
               ),
             );
           } else {
@@ -426,7 +426,7 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
       builder: (context, child) {
         if (child == null) {
           return const CenteredMessage(
-            'Uh-oh, something went wrong. Please refresh the page.',
+            message: 'Uh-oh, something went wrong. Please refresh the page.',
           );
         }
         return MultiProvider(

diff --git a/packages/devtools_app/lib/src/framework/initializer.dart b/packages/devtools_app/lib/src/framework/initializer.dart
@@ -79,7 +79,7 @@ class _InitializerState extends State<Initializer>
           children: [
             const Spacer(),
             CenteredMessage(
-              _showConnectToNewAppButton
+              message: _showConnectToNewAppButton
                   ? 'Cannot connect to VM service.'
                   : 'Waiting for VM service connection...',
             ),

diff --git a/packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart b/packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart
@@ -394,7 +394,7 @@ class _AnalysisViewState extends State<AnalysisView>
       valueListenable: controller.processingNotifier,
       builder: (context, processing, _) {
         return processing
-            ? const CenteredMessage(AppSizeScreen.loadingMessage)
+            ? const CenteredMessage(message: AppSizeScreen.loadingMessage)
             : Column(
                 children: [
                   Flexible(
@@ -498,7 +498,7 @@ class _DiffViewState extends State<DiffView>
       valueListenable: controller.processingNotifier,
       builder: (context, processing, _) {
         return processing
-            ? const CenteredMessage(AppSizeScreen.loadingMessage)
+            ? const CenteredMessage(message: AppSizeScreen.loadingMessage)
             : Column(
                 crossAxisAlignment: CrossAxisAlignment.stretch,
                 children: [

diff --git a/packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart b/packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart
@@ -97,7 +97,7 @@ class _DeepLinkListViewMainPanel extends StatelessWidget {
           case PagePhase.noLinks:
             // TODO(hangyujin): This is just a place holder to add UI.
             return const CenteredMessage(
-              'Your Flutter project has no Links to verify.',
+              message: 'Your Flutter project has no Links to verify.',
             );
           case PagePhase.analyzeErrorPage:
             assert(controller.currentAppLinkSettings?.error != null);
@@ -125,7 +125,7 @@ class _DeepLinkListViewMainPanel extends StatelessWidget {
 
           case PagePhase.validationErrorPage:
             // TODO(hangyujin): This is just a place holder to add Error handling.
-            return const CenteredMessage('Error validating domain ');
+            return const CenteredMessage(message: 'Error validating domain ');
         }
       },
     );

diff --git a/packages/devtools_app/lib/src/screens/inspector/layout_explorer/flex/flex.dart b/packages/devtools_app/lib/src/screens/inspector/layout_explorer/flex/flex.dart
@@ -441,7 +441,7 @@ class _VisualizeFlexChildrenState extends State<VisualizeFlexChildren> {
     }
 
     if (!widget.properties.hasChildren) {
-      return const CenteredMessage('No Children');
+      return const CenteredMessage(message: 'No Children');
     }
 
     final theme = Theme.of(context);

diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/flex/flex.dart b/packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/flex/flex.dart
@@ -442,7 +442,7 @@ class _VisualizeFlexChildrenState extends State<VisualizeFlexChildren> {
     }
 
     if (!widget.properties.hasChildren) {
-      return const CenteredMessage('No Children');
+      return const CenteredMessage(message: 'No Children');
     }
 
     final theme = Theme.of(context);

diff --git a/...s/devtools_app/lib/src/screens/memory/panes/diff/widgets/class_details/class_details.dart b/...s/devtools_app/lib/src/screens/memory/panes/diff/widgets/class_details/class_details.dart
@@ -30,7 +30,7 @@ class HeapClassDetails extends StatelessWidget {
     final data = classData;
     if (data == null) {
       return const CenteredMessage(
-        'Click a table row to see retaining paths here.',
+        message: 'Click a table row to see retaining paths here.',
       );
     }
 
@@ -45,7 +45,7 @@ class HeapClassDetails extends StatelessWidget {
       builder: (_, pathData, __) {
         if (pathData == null) {
           return const CenteredMessage(
-            'Click a table row to see the detailed path.',
+            message: 'Click a table row to see the detailed path.',
           );
         }
 

diff --git a/packages/devtools_app/lib/src/screens/performance/tabbed_performance_view.dart b/packages/devtools_app/lib/src/screens/performance/tabbed_performance_view.dart
@@ -136,7 +136,7 @@ class _TabbedPerformanceViewState extends State<TabbedPerformanceView>
                         controller.flutterFramesController.displayRefreshRate,
                   )
                 : const CenteredMessage(
-                    'Select a frame above to view analysis data.',
+                    message: 'Select a frame above to view analysis data.',
                   ),
           ),
           featureController: null,

diff --git a/packages/devtools_app/lib/src/screens/profiler/profiler_status.dart b/packages/devtools_app/lib/src/screens/profiler/profiler_status.dart
@@ -69,7 +69,7 @@ class EmptyProfileView extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return const CenteredMessage('No CPU samples recorded.');
+    return const CenteredMessage(message: 'No CPU samples recorded.');
   }
 }
 

diff --git a/packages/devtools_app/lib/src/screens/provider/instance_viewer/eval.dart b/packages/devtools_app/lib/src/screens/provider/instance_viewer/eval.dart
diff --git a/packages/devtools_app/lib/src/screens/provider/instance_viewer/fake_freezed_annotation.dart b/packages/devtools_app/lib/src/screens/provider/instance_viewer/fake_freezed_annotation.dart