Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure release_helper.sh creates PRs on main repo #6318

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Ensure release_helper.sh creates PRs on main repo #6318

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
229a162
point specifically to repo
CoderDake Aug 30, 2023
ca78b18
add x for now
CoderDake Aug 30, 2023
2fb722d
add dummy commit
CoderDake Aug 30, 2023
51b117e
better targ
CoderDake Aug 30, 2023
91d1082
fill
CoderDake Aug 30, 2023
ea2f7d6
no more fill arg
CoderDake Sep 5, 2023
36a153f
cleanup
CoderDake Sep 5, 2023
0769aa3
Apply suggestions from code review
CoderDake Sep 5, 2023
c0c6c19
Merge branch 'master' into fix-release-help
CoderDake Sep 5, 2023
af9e65f
Update tool/release_helper.sh
CoderDake Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tool/release_helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ git push -u $DEVTOOLS_REMOTE $RELEASE_BRANCH
echo "Creating the PR"
echo

PR_URL=$(gh pr create --draft --title "$COMMIT_MESSAGE" $CREATION_FLAGS)
PR_URL=$(gh pr create --repo flutter/devtools --draft --title "$COMMIT_MESSAGE" --fill)


echo "Updating your flutter version to the most recent candidate."
Expand All @@ -59,4 +59,6 @@ echo

echo "Your Draft release PR can be found at: $PR_URL"
echo
echo "$0 DONE: Build, run and test this release using: `dart ./tool/build_e2e.dart`"
echo "$0 DONE: Build, run and test this release using: `dart ./tool/build_e2e.dart`"
CoderDake marked this conversation as resolved.
Show resolved Hide resolved

exit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding new line to the end of file to remove this red sign?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-05 at 8 08 38 AM

CoderDake marked this conversation as resolved.
Show resolved Hide resolved