-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
called getFullRequestData() before export #8333
called getFullRequestData() before export #8333
Conversation
@kenzieschmoll please check this, if this looks ok can we add this as a hotfix in beta? |
await item.getFullRequestData(); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to await them all in one operation instead of awaiting each call to getFullRequestData
before requesting the next? So something like:
Future<void> _fetchFullDataBeforeExport() =>
Future.wait(filteredData.value.whereType<DartIOHttpRequestData>());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will optimise it, I had thought of doing it earlier but I missed changing it.
Thanks @julemand101
Changed it to -
`Future _fetchFullDataBeforeExport() =>
Future.wait(
filteredData.value
.whereType<DartIOHttpRequestData>()
.map((item) => item.getFullRequestData()),
);`
@kenzieschmoll do you have any feedback on this? if not can this be merged @bkonyi |
I think this is safe to be merged without explicit approval from @kenzieschmoll but we should update the release notes at |
Fixes bug -
Not able to see response content in exported har for few requests.
List which issues are fixed by this PR.
#8253
Please add a note to
packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.Pre-launch Checklist
///
).If you need help, consider asking for help on Discord.