[deep link] Ignore invalid aasa paths (path is null or empty, but has a queryParams) #8339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
requested review from
elliette and
kenzieschmoll
and removed request for
a team and
elliette
hannah-hyj
changed the title
| @@ -209,6 +209,10 @@ class DeepLinksService { | |||
| ?.cast<Map<String, Object?>>(); | |||
| if (aasaPaths != null) { | |||
| for (final aasaPath in aasaPaths) { | |||
| final path = aasaPath[_pathKey] as String?; | |||
| if (path?.isEmpty ?? true) { | |||
There was a problem hiding this comment.
use the isNullOrEmpty helper instead
kenzieschmoll
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR.
Please add a note to
packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.mdif your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.Pre-launch Checklist
///).If you need help, consider asking for help on Discord.