-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deep link] Flip flag deepLinkIosCheck value to true
#8394
Conversation
Update NEXT_RELEASE_NOTES.md
@@ -68,7 +68,7 @@ TODO: Remove this section if there are not any general updates. | |||
|
|||
## Deep links tool updates | |||
|
|||
TODO: Remove this section if there are not any general updates. | |||
- Added support for validating ios deep link settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a screenshot to the release notes and a link to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, thanks!
@@ -68,7 +68,9 @@ TODO: Remove this section if there are not any general updates. | |||
|
|||
## Deep links tool updates | |||
|
|||
TODO: Remove this section if there are not any general updates. | |||
- Added support for validating ios deep link settings. - [#8394](https://github.com/flutter/devtools/pull/8394) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment then lgtm
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR.
Please add a note to
packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.Pre-launch Checklist
///
).If you need help, consider asking for help on Discord.