Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Logging V2 metadata and controls display #8406

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

kenzieschmoll
Copy link
Member

Screenshot 2024-10-04 at 1 36 04 PM

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner October 4, 2024 20:40
@kenzieschmoll kenzieschmoll requested review from elliette and removed request for a team October 4, 2024 20:40
@@ -87,7 +87,7 @@ abstract class FeatureFlags {
/// Flag to enable the new Logging experience.
///
/// https://github.com/flutter/devtools/issues/7703
static bool loggingV2 = enableExperiments;
static bool loggingV2 = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. good catch!

@kenzieschmoll kenzieschmoll merged commit b7b3b79 into flutter:master Oct 4, 2024
23 checks passed
@kenzieschmoll kenzieschmoll deleted the loggingv2 branch October 4, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants