Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS updates #11140

Merged
merged 4 commits into from
Sep 20, 2024
Merged

iOS updates #11140

merged 4 commits into from
Sep 20, 2024

Conversation

sfshaza2
Copy link
Contributor

@sfshaza2 sfshaza2 commented Sep 15, 2024 •
edited by parlough
Loading

@sfshaza2 sfshaza2 requested review from parlough, jmagman and a team as code owners September 15, 2024 21:33
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 15, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit df3e5e7):

https://flutter-docs-prod--pr11140-ios-nj1tdscm.web.app

@domesticmouse domesticmouse changed the title Ios updates iOS updates Sep 16, 2024
@sfshaza2
Copy link
Contributor Author

@jmagman @sethladd, I'd like to land this unless it has any egregious errors.

@jmagman
Copy link
Member

jmagman commented Sep 17, 2024

@jmagman @sethladd, I'd like to land this unless it has any egregious errors.

It still has placeholder text for the Cupertino widgets.

@sfshaza2
Copy link
Contributor Author

@jmagman, I've removed the placeholder text. we can refine the actual text later

jmagman
jmagman reviewed Sep 17, 2024
View reviewed changes
src/content/platform-integration/ios/ios-latest.md
| iOS formatting menu | On Flutter roadmap. Not yet available. |
|**Translate** support for the context edit menu | On Flutter roadmap. Not yet available. |
| Target and build for iOS 18 | Tested. Should just work. |
| Cupertino widget A and B | New! |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still placeholder text.

I don't think this chart is quite ready, for example "should just work" doesn't sound very confident, I don't particularly want to frame it like this.

I definitely want to land removing the "beta" references on the other two pages, but can we hold off landing this new page until we've refined the wording?

@parlough parlough mentioned this pull request Sep 18, 2024
Merged
parlough added a commit that referenced this pull request Sep 18, 2024
@parlough @sfshaza2
Update references to iOS 18 beta and release (#11160)
d8acea9 
Extracted with some modifications and additions from
#11140

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
@parlough
Copy link
Member

Just noting I pulled out the other beta/release note updates to #11160 and updated this PR with those changes from main, so this PR can focus on the new page.

@domesticmouse domesticmouse merged commit f5c2efc into main Sep 20, 2024
9 checks passed
@sethladd
Copy link
Contributor

Hi all, it looks like we're not quite ready to land this page as-is (there's still some placeholder text, and there's some phrasing we want to tweak). I see https://docs.flutter.dev/platform-integration/ios/ios-latest is live. Should we un-publish this page, or make a fast-follow fix?

@sethladd
Copy link
Contributor

Looks like there were updates after this PR landed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman left review comments

@domesticmouse domesticmouse domesticmouse approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfshaza2 @flutter-website-bot @jmagman @parlough @sethladd @domesticmouse