Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge arcgis web #42

Merged
merged 19 commits into from
Nov 10, 2023
Merged

Merge arcgis web #42

merged 19 commits into from
Nov 10, 2023

Conversation

MatthaiosSait
Copy link
Collaborator

@MatthaiosSait MatthaiosSait commented Jun 7, 2023

Merge the newer features of arcgis web

Already merged:

Web functionality bug:

  • Show vector layer

iOs functionality bug:

  • Add polygon
  • Toggle Basemap

Android functionality bug:

  • Add polygon

Copy link
Collaborator

@maxpeters maxpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 🌮

Copy link
Collaborator Author

@MatthaiosSait MatthaiosSait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there are minimal changes for the iOs and Android implementations.

@@ -100,20 +74,6 @@ extension FieldJsonExtension on Field {
};
}

extension ArcGisMapAttributesJsonExtension on ArcGisMapAttributes {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore because Attributes has now a Map parameter.

/// Examples of polygon areas
final List<List<LatLng>> redPolygon = [
<List<double>>[
const List<List<List<double>>> redPolygon = [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it back to List<double>.
Let's see in a following PR if it makes sense for every platform to change it back to LatLng

@MatthaiosSait MatthaiosSait merged commit f81d485 into main Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants