51-avoid-crashing-when-native-call-fails #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianBissekkou
commented
Nov 27, 2023
Comment on lines
+1
to
+13
| // | ||
| // ParseException.swift | ||
| // arcgis_map_sdk_ios | ||
| // | ||
| // Created by Julian Bissekkou on 26.11.23. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
|
|
||
| struct ParseException: Error { | ||
| let message: String | ||
| } |
There was a problem hiding this comment.
When checking the branch locally on your maschine, do you see this file in xcode?
Works on my maschine, but I would expect a change in the xcode project file that references to this new file...
There was a problem hiding this comment.
Yes, but I made some suggested updates in the pods. I don't know if it influenced anything.
MatthaiosSait
approved these changes
Dec 4, 2023
|
|
||
| return points.map { subPoints -> | ||
| Graphic().apply { | ||
| geometry = Polyline(PointCollection(subPoints.map { it.toAGSPoint() })) | ||
| geometry = Polyline(PointCollection(subPoints.map { coordinateArray -> |
There was a problem hiding this comment.
Polyline fix works 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error handling a little bit by catching native exceptions and providing an error message without terminating the process.
I also fixed the polyline implementation on mobile which failed to parse the coordinates in the payload.