package upgrades #842
package upgrades #842
Conversation
|
@diegotori please let me know if there's a requirement of updating the files in android folder according to the new migration guide https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply will be happy to contribute!! |
|
@vaishnavi-2301 please address the lint issues. Also, since this library is merely a UI layer over |
…n material_controls.dart and material_desktop_controls.dart
|
@diegotori Hey, addressed the lint issues. kindly review and let me know if there's anything required. |
There was a problem hiding this comment.
Please ensure that the Android example app is closely configured based on this example from wakelock_plus.
The reason being is that I recently had to shake some bugs when actually building the migrated Android app. The example that I linked you to should be the gold standard in terms of that.
Mainly, it involves building the app against Java 17, but please cross-check your changes against that example.
Thanks in advance.
|
Thanks for the reference....have updated the files according to it. appologies for the delay. |
example/android/app/build.gradle
Outdated
| minSdkVersion 21 | ||
| targetSdkVersion 33 | ||
| applicationId "com.example.example" | ||
| minSdk 24 |
There was a problem hiding this comment.
@vaishnavi-2301 Is there any reason why minSdk on Android needs to be set at 24?
Unless you cite where it needs to be set that high, please set it to 21, which is the bare minimum that Flutter now supports. Thanks.
There was a problem hiding this comment.
Okay will change it to the 21
|
@vaishnavi-2301 added in version |
Update compileSdkVersion and dependencies.