-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Caliper integration and instrumentation #130
Open
slabasan
wants to merge
17
commits into
flux-framework:main
Choose a base branch
from
slabasan:caliper-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slabasan
changed the title
WIP Caliper integration
WIP Caliper integration and instrumentation
May 10, 2024
slabasan
force-pushed
the
caliper-integration
branch
4 times, most recently
from
May 10, 2024 17:45
5504b98
to
efc3e39
Compare
slabasan
force-pushed
the
caliper-integration
branch
from
September 27, 2024 23:34
b43125d
to
48b5b29
Compare
needs updates for make build systems
slabasan
force-pushed
the
caliper-integration
branch
from
September 28, 2024 13:44
2cd73fe
to
e4c3f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #118
TODO:
find_package(caliper)
should follow current pattern with other dependencies (this was initially done before we refactored thefind_package
calls after running into issues on turing)config/*.cmake
files to indicate to external software that perfflowaspect was built (or not built) with caliper --> bigger lift as this will require testing integration of PFA+caliper with other software tools, maybe this becomes a second PR, but realistically should be a single PR since external tools will link against these cmake filesCopying over notes from #118:
Couple of things before we can merge:
LLVM function names that get passed to Caliper (eg
_Z3fooRKs
instead of justfoo
) look confusing and don't match the original function name. Let's see if we can do better.Caliper should not be "required" library. Many users may not need low-level perf counter details on their workflow and may just want the timeline traces. So, we need to add in an option/flag that determines if PFA should be built with Caliper for users who want something fine grained. With multiple workflow components eg in MuMMI or AHA Moles, we don't need this detail all the time and simple timelines are sufficient.
We need to update the CI to match these build changes (we need to build caliper in the CI tests)
We need to add detailed docs:
CALI_CONFIG=runtime-report ./smoketest
orCALI_CONFIG=runtime-report,output=test.cali ./smoketest
or something with cali-query) and show the corresponding generated output, and