-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable option to toggle between array and object format #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slabasan
changed the title
Enable option to toggle between array and object format
WIP Enable option to toggle between array and object format
Apr 5, 2024
slabasan
changed the title
WIP Enable option to toggle between array and object format
Enable option to toggle between array and object format
Apr 8, 2024
slabasan
force-pushed
the
output-object-format
branch
from
April 16, 2024 22:02
86408a7
to
e010649
Compare
slabasan
force-pushed
the
output-object-format
branch
from
April 24, 2024 21:04
e010649
to
ad1b01d
Compare
- add unit test to output object pfw file - update expected pfw filenames in unit tests
slabasan
force-pushed
the
output-object-format
branch
from
April 24, 2024 21:12
ad1b01d
to
bf7187d
Compare
We'll merge after the following tests.
|
All tests are complete. This is ready to merge. |
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
TODO:
displayTimeUnit
as ms or ns. But in PFA, we are converting to microsec. Please check how the value of displayTimeUnit impacts the visualization in Perfetto (if at all). Then this is ready for merge.Viewable in perfetto (without closing brackets):