plugin: keep jobs in PRIORITY after reprioritization
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the priority plugin will raise an exception on a job if it is held in SCHED state while the plugin is reloaded (or Flux is restarted) and jobs are reprioritized without first loading flux-accounting data to this plugin. This behavior is not graceful and we should instead continue to hold a job in PRIORITY while the plugin waits to receive flux-accounting data. Add a check of the plugin's internal map to see if we are still waiting on flux-accounting data to be loaded in; if so, continue to hold the job while we wait for data. Add a sharness test that reproduces the issue raised in flux-framework#406 and ensure that jobs continue to be held after a reprioritization without loading flux-accounting data to the priority plugin.
cmoussa1
added
bug-fix
|
Thanks @grondo! Sure, I can generate a release today and have a ticket submitted by COB tomorrow so that it can go in the next TOSS release. Will work on this now 👍 setting MWP here |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 20 20
Lines 1437 1437
=======================================
Hits 1164 1164
Misses 273 273
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noted in #406, the priority plugin will raise an exception on a job if it is held in
SCHEDstate while the plugin is reloaded (or Flux is restarted) and jobs are reprioritized without first loading flux-accounting data to this plugin. This behavior is not graceful and we should instead continue to hold a job inPRIORITYwhile the plugin waits to receive flux-accounting data.This PR adds a check of the plugin's internal map to see if we are still waiting on flux-accounting data to be loaded in; if so, it will continue to hold the job while we wait for data.
I've also added a sharness test that reproduces the issue raised in #406 and ensures that jobs continue to be held after a reprioritization without loading flux-accounting data to the priority plugin.