plugin: improve callback for job.new
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The callback for job.new still performs a manual lookup of an Association, but there now exists external functions defined in accounting.cpp that the callback should make use of. It is also lacking a function description and has some leftover variables that are unutilized. Clean up this function by using the new external functions that perform lookups of an association. Remove unused variables from the function. Add a function description at the top.
Problem: The job.new callback has some extra whitespace and misaligned indention. Remove the extra whitespace and fix the misaligned indentation.
cmoussa1
added
improvement
|
Appreciate it thanks! Setting MWP here |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 82.42% 82.48% +0.05%
==========================================
Files 23 23
Lines 1457 1439 -18
==========================================
- Hits 1201 1187 -14
+ Misses 256 252 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Continuing the cleanup and abstraction of the code within the priority plugin, this time for the
job.newcallback.This PR cleans up the callback for
job.newby using the new external functions that perform lookups of an association. It removes unused variables from the function. It also adds a function description at the top and some additional comments within the function. Finally, it fixes some misaligned and extra whitespace.Fixes #419