Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: add jansson as a dependency check #484

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

cmoussa1
Copy link
Member

Problem

As noted in #364, flux-accounting does not check for jansson when running ./configure even though it uses it in the priority plugin.


This PR adds a check for jansson in configure.ac.

Fixes #364

@cmoussa1 cmoussa1 added the improvement Upgrades to an already existing feature label Aug 14, 2024
@cmoussa1 cmoussa1 requested a review from garlick August 14, 2024 17:12
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Problem: flux-accounting does not check for jansson when running
./configure even though it uses it in the priority plugin.

Add a check for jansson in configure.ac.
@cmoussa1
Copy link
Member Author

Thanks! Setting MWP here

@cmoussa1 cmoussa1 removed the request for review from garlick August 28, 2024 19:57
@mergify mergify bot merged commit 658afac into flux-framework:master Aug 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Upgrades to an already existing feature merge-when-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: dependencies may need adjustment
2 participants