cmd: add pop-db as a flux account command
#487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The "pop-db" command is located in a separate file in the src/cmd/ directory and thus requires a different method of calling it than the other flux-accounting commands, i.e you need to write "flux account-pop-db" instead of "flux account pop-db". Move this file to the directory containing the other Python bindings for flux-accounting and add it as a regular command like the other bindings so that you can just call it like "flux account pop-db". Remove the methods and command line argument that deal with establishing a connection to the flux-accounting DB since the systemd service will handle establishing that connection. Adjust the calls in the sharness tests and top-level README for pop-db to account for the change.
Problem: t1026-flux-account-perms.t goes through all of the flux account commands that require admin privileges to run and makes sure that they cannot be accessed by regular users, but it does not test the "export-db" or "pop-db" commands. Add both of these commands to the test suite to ensure they require admin privileges to be run.
|
thanks! setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
pop-dbcommand is located in a separate file in thesrc/cmd/directory and thus requires a different method of calling it than the other flux-accounting commands, i.e you need to writeflux account-pop-dbinstead offlux account pop-db.This PR moves this file to the directory containing the other Python bindings for flux-accounting and adds it as a regular command like the other bindings so that you can just call it like
flux account pop-db.It removes the methods and
--pathcommand line argument that deal with establishing a connection to the flux-accounting DB since the systemd service will handle establishing that connection.I've also added both
pop-dbandexport-dbas commands that are tested int1026-flux-account-perms.tto ensure that they require admin privileges to be run.Finally, it adjusts the calls in
t1009-pop-db.tandt1016-export-db.tand top-level README forpop-dbto account for the change.