JobRecord: remove username from __init__() of JobRecord object
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The "username" field is automatically populated when userid is passed into the construction of a JobRecord object, but it is listed as an attribute during initialization. Remove "username" from the list of attributes needed to be passed in. Explicitly state which fields are being assigned to which member of a JobRecord object instead of labeling them via comments.
The function description for get_jobs() has a spelling mistake. Fix it.
|
Thank you! Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
usernamefield is automatically populated whenuseridis passed into the construction of aJobRecordobject, but it is listed as an attribute during initialization.This PR removes
usernamefrom the list of attributes in__init__(). It also explicitly labels which fields are being assigned to which member of theJobRecordobject instead of labeling them via comments.I've also snuck in a spelling correction commit at the end of this PR.