view-job-records: add --project filter option
#490
Merged
+147
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There is no way to filter jobs by project when looking at job records in flux-accounting's "jobs" table. Add a "project" column to the jobs table that will store an optional project name for each job. Update the schema version of the DB with the addition of the column name. Add an option to filter jobs by "project" when adding job records to the "jobs" table and while looking at job records with the view-job-records command.
Problem: A new column is added to the "jobs" table, but the test file that tests updating previous versions of flux-accounting DBs does not contain the schema version of the DB before this addition. Add the flux-accounting DB from v0.37.0 to the set of DBs tested in an update in t1017-update-db.t.
Problem: There is a helper script that inserts test job records into the "jobs" table that needs its INSERT statement to be updated to account for the addition of the "project" column. There is also an expected output file that needs to be updated to also account for the new "Project" column in the output of the view-job-records command. Update both of these in accordance with the addition of the "project" column to the "jobs" table in the flux-accounting DB.
Problem: There are no tests that ensure filtering jobs by project works. Add some basic tests.
|
@ryanday36 would you like to give this PR a high-level look and let me know if this might be a useful feature? I thought this might be a first-crack at tackling #352 to make it easier to gather jobs by project. |
|
This definitely looks useful! Thanks @cmoussa1 |
|
Sounds great @ryanday36! Thanks for taking a look at it. I'll mark this as ready for review then. |
|
Thanks @jameshcorbett! Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to filter jobs by project when looking at job records in flux-accounting's
jobstable. This could be a useful feature now that the priority plugin validates and annotates project names for jobs.This PR adds a
projectcolumn to thejobstable that can store an optional project name for each job. It then adds an optional argument to theview-job-recordscommand--projectwhich can filter jobs by project name:flux account view-job-records --project=projectAI've updated some existing tests that use the
view-job-recordscommand as well as added a new test file that tests filtering jobs by project name.