flux-account.py: get rid of dictionary initialization
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
cmoussa1
force-pushed
the
clean.flux-account
branch
2 times, most recently
from
5798718 to
c9c0656
Compare
Problem: flux-account.py manually creates the dictionary of arguments that is sent via RPC to the flux-accounting service, but since the service already unpacks these arguments, flux-account.py can just create a dictionary of the arguments using vars() and send the entire dictionary. Use vars() on the parsed args to create a dictionary before sending the RPC to the appropriate flux-accounting command. Move the .split() call of the "fields" optional argument to the flux-accounting service instead of in flux-account.py.
cmoussa1
force-pushed
the
clean.flux-account
branch
from
c9c0656 to
f31e771
Compare
|
Thanks! Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
flux-account.pymanually creates the dictionary of arguments that is sent via RPC to the flux-accounting service, but since the service already unpacks these arguments,flux-account.pycan just create a dictionary of the arguments usingvars()and send the dictionary without having to define each key-value pair before sending the RPC.This PR changes
flux-account.pyto just usevars()on the parsed args to create a dictionary before sending the RPC to the appropriate flux-accounting command.