Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add priority equation to accounting guide #513

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

garlick
Copy link
Member

@garlick garlick commented Oct 16, 2024

Problem: the accounting guide uses words to describe how priority is calculated but math would be clearer.

Add "queue" to the lists of factors and format the list as a dictionary rather than a bullet list.

Use a math expression for the priority value.

I briefly looked at the code and priority appeared to be calculated this way - did I get it right?

Problem: the accounting guide uses words to describe how
priority is calculated but words would be clearer.

Add "queue" to the lists of factors and format the list as a dictionary
rather than a bullet list.

Use a math expression for the priority value.
@garlick
Copy link
Member Author

garlick commented Oct 16, 2024

(oops fixed a typo and forced a push)

Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this @garlick

@garlick
Copy link
Member Author

garlick commented Oct 16, 2024

Just to confirm, so the urgency factor has a weight of 1 and we subtract 16 from it before adding?

@cmoussa1
Copy link
Member

You are correct, it has a weight of 1.

@garlick
Copy link
Member Author

garlick commented Oct 16, 2024

OK, I'll set MWP then. Thanks!

@mergify mergify bot merged commit f45add7 into flux-framework:master Oct 16, 2024
13 checks passed
@garlick garlick deleted the priority_math branch October 17, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants