-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t: skip t1011 if job-archive module not detected, add new tests for fetch-job-records
#518
Conversation
Why not just remove the tests that rely on job-archive, since flux-accounting is no longer using job-archive? Then perhaps this could just be one commit, saying something like "we aren't using job-archive anymore, rework to rely on ..."? |
I think we thought about it briefly in the thread #517, but we are not 100% sure if there are old-enough versions of flux-accounting that are still running on our systems that still rely on the job-archive module? i.e |
My concern was that we don't necessarily want to lose coverage for reading and parsing the |
I was going with this assumption that we were long past systems using |
I think I'll just go ahead and drop those tests - I don't think versions of flux-accounting |
Problem: t1011-job-archive-interface.t relies on the job-archive module in flux-core which is being considered for removal in flux-framework/flux-core#6378 since flux-accounting now has that capability on its own. Edit the tests that use the job-archive module and just use flux-accounting's fetch-job-records script to fetch inactive job records.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! Setting MWP here |
Problem
Mentioned in #517,
t1011-job-archive-interface.t
relies on the job-archive modulein flux-core which is being considered for removal in
flux-framework/flux-core#6378 since flux-accounting now has that
capability on its own.
This PR adds a check in
t1011-job-archive-interface.t
that will skip the test file in the event that the job-archive module does not exist.I've also added a new file to the test suite that very similarly runs through the same tests in
t1011
but does not rely at all on the detection of the job-archive module.