Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS.md: add release notes for v0.52.0 #5316

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

garlick
Copy link
Member

@garlick garlick commented Jul 6, 2023

Release notes for 0.52. Change as needed!

This assumes the PRs added to the 0.52 milestone are going to be merged first.

@garlick garlick added this to the flux-core v0.52.0 milestone Jul 6, 2023
@chu11
Copy link
Member

chu11 commented Jul 6, 2023

pushed a fixup, i think one of the features is really a fix.

optionally, dunno what people's opinions are here .. this feature

python: support "original" option in job kvslookup module (#5311)

adds a feature to the new addition ...

python: support convenience API for job-info.lookup RPC / "flux job info" (#5265)

So it's sort of a feature on top of a new feature ... we could just remove the first one, it maybe isn't necessary?

@grondo
Copy link
Contributor

grondo commented Jul 7, 2023

So it's sort of a feature on top of a new feature ... we could just remove the first one, it maybe isn't nece

I'll sometimes combine those when I spot them in the NEWS, e.g.

 * python: support convenience API for `job-info.lookup` RPC / "flux job
   info" (#5265, #5311)

@grondo
Copy link
Contributor

grondo commented Jul 7, 2023

I'll go ahead and make that change, squash the fixups, and force push the result.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #5316 (4ec263b) into master (3f45e14) will increase coverage by 27.84%.
The diff coverage is n/a.

❗ Current head 4ec263b differs from pull request most recent head 01b6ac1. Consider uploading reports for the commit 01b6ac1 to get more accurate results

@@             Coverage Diff             @@
##           master    #5316       +/-   ##
===========================================
+ Coverage   55.49%   83.33%   +27.84%     
===========================================
  Files         422      463       +41     
  Lines       71991    78722     +6731     
===========================================
+ Hits        39948    65601    +25653     
+ Misses      32043    13121    -18922     

see 385 files with indirect coverage changes

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grondo
Copy link
Contributor

grondo commented Jul 7, 2023

Thanks @garlick for doing this! I'll give it an hour or so then set MWP.

@garlick
Copy link
Member Author

garlick commented Jul 7, 2023

Could we get #5309 and #5298 merged first? They need a quick review.

@grondo
Copy link
Contributor

grondo commented Jul 7, 2023

Sure, sorry I missed those. Both PRs are approved now.

@garlick
Copy link
Member Author

garlick commented Jul 7, 2023

Thanks!

@grondo
Copy link
Contributor

grondo commented Jul 7, 2023

Ok, setting MWP. Edit: after pending PRs are merged.

@garlick
Copy link
Member Author

garlick commented Jul 7, 2023

Just checking in and I see the other PRs are merged, so I'll set mwp here.

Problem: There are no release notes for flux-core v0.52.0.

Update NEWS.md with notes of changes since v0.51.0.
@mergify mergify bot merged commit a57a525 into flux-framework:master Jul 7, 2023
@garlick garlick deleted the news-0.52 branch July 7, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants