bug: context missing from EventsToRegister

Problem: the custom scheduler plugin interface now requires a context variable (which is empty/not used) Solution: add context.Context for it. Signed-off-by: vsoch <[email protected]>
flux-framework · Dec 8, 2024 · 363f1d8 · 363f1d8
1 parent 29f411e
commit 363f1d8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/sig-scheduler-plugins/pkg/fluence/fluence.go b/sig-scheduler-plugins/pkg/fluence/fluence.go
@@ -140,14 +140,15 @@ func (fluence *Fluence) Name() string {
 
 // Fluence has added delete, although I wonder if update includes that signal
 // and it's redundant?
-func (fluence *Fluence) EventsToRegister() []framework.ClusterEventWithHint {
+func (fluence *Fluence) EventsToRegister(_ context.Context) ([]framework.ClusterEventWithHint, error) {
 	// To register a custom event, follow the naming convention at:
-	// https://git.k8s.io/kubernetes/pkg/scheduler/eventhandlers.go#L403-L410
+	// https://github.com/kubernetes/kubernetes/pull/101394
+	// Please follow: eventhandlers.go#L403-L410
 	podGroupGVK := fmt.Sprintf("podgroups.v1alpha1.%v", scheduling.GroupName)
 	return []framework.ClusterEventWithHint{
 		{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Add | framework.Delete}},
 		{Event: framework.ClusterEvent{Resource: framework.GVK(podGroupGVK), ActionType: framework.Add | framework.Update | framework.Delete}},
-	}
+	}, nil
 }
 
 // TODO we need to account for affinity here