Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Gitea client test e2e #236

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Declare Gitea client test e2e #236

merged 1 commit into from
Jun 20, 2023

Conversation

makkes
Copy link
Member

@makkes makkes commented Jun 20, 2023

This is necessary to get rid of the external dependency on try.gitea.io and instead use the ephemeral instance spun up as part of e2e testing.

It makes us independent of bugs in Gitea that are deployed at try.gitea.io, e.g. go-gitea/gitea#25350.

This is necessary to get rid of the external dependency on
try.gitea.io and instead use the ephemeral instance spun up as part of
e2e testing.

Signed-off-by: Max Jonas Werner <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes

@makkes makkes merged commit 2200758 into main Jun 20, 2023
@makkes makkes deleted the remove-ext-dep-gitea branch June 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants