Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config checksum from event metadata to rate limiting key #518

Closed
wants to merge 2 commits into from

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Apr 30, 2023

@matheuscscp matheuscscp changed the title Config hash Add config checksum from event metadata to rate limiting key Apr 30, 2023
@hiddeco
Copy link
Member

hiddeco commented May 1, 2023

First wondered if the more generic approach to this would be to pass on the generation of the involved object, and take this into account. However, this would not cover for things which may produce different results due to to e.g. contents of referenced Secrets and/or ConfigMap changing (as could be the case for Helm values).

@matheuscscp
Copy link
Member Author

First wondered if the more generic approach to this would be to pass on the generation of the involved object, and take this into account. However, this would not cover for things which may produce different results due to to e.g. contents of referenced Secrets and/or ConfigMap changing (as could be the case for Helm values).

But nice catch! We could also add the object generation anyways 🤔 Should I update this PR or open another one?

@matheuscscp
Copy link
Member Author

@hiddeco What are the next steps here now that fluxcd/pkg#544 got merged?

@hiddeco
Copy link
Member

hiddeco commented May 4, 2023

Update the other PRs to properly working with this, while the actual tagging of the event API package is pending you can use a revision from main in the PRs.

@matheuscscp
Copy link
Member Author

Superseded by #530

@matheuscscp matheuscscp deleted the config-hash branch May 19, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm upgrade succeeded event throttled even though .spec.values has changed
2 participants