Promote Helm APIs to source.toolkit.fluxcd.io/v1 (GA)
#1428
Conversation
stefanprodan
added
area/helm
stefanprodan
changed the title
source.toolkit.fluxcd.io/v1 (GA)
|
Please consider integrating #1447: this is currently a blocker on our adoption of FluxCD, and it would be awesome to see this come with Flux v2.3.0 and the GA of these APIs. |
|
@isometry that PR is taking to long and we can't delay the next release further. We plan to release SC by the end of the week. |
|
Understood. I'll try and get this wrapped up tonight. |
|
@stefanprodan : #1447 is now updated. If you think it's ready… :-) |
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
Signed-off-by: Stefan Prodan <[email protected]>
| @@ -50,7 +50,7 @@ import ( | |||
| "github.com/fluxcd/pkg/runtime/pprof" | |||
| "github.com/fluxcd/pkg/runtime/probes" | |||
|
|
|||
| v1 "github.com/fluxcd/source-controller/api/v1" | |||
| "github.com/fluxcd/source-controller/api/v1" | |||
There was a problem hiding this comment.
Nit: I feel we should keep calling this sourcev1 to remain consistent across the codebase
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| apiVersion: source.toolkit.fluxcd.io/v1beta2 | |||
| apiVersion: source.toolkit.fluxcd.io/v1 | |||
There was a problem hiding this comment.
what about the other files in config/testdata/git and config/testdata/helmchart-valuesfile?
There was a problem hiding this comment.
I would leave all of these of on the beta version to ensure backwards comparability. I only bumped the samples who are part of e2e.
Signed-off-by: Stefan Prodan <[email protected]>
This PR promotes the HelmRepository and HelmChart APIs from v1beta2 to v1 and removes the following deprecated fields from the HelmChart API:
.spec.valuesFilereplaced by.spec.valuesFilesPart of: fluxcd/flux2#4712