Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support for OCIRepository API #1536

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Add proxy support for OCIRepository API #1536

merged 1 commit into from
Aug 15, 2024

Conversation

matheuscscp
Copy link
Collaborator

Fixes #1492

@matheuscscp matheuscscp force-pushed the ocirepo-proxy branch 3 times, most recently from 33ee8b6 to 2ccda4a Compare July 4, 2024 13:29
@matheuscscp matheuscscp marked this pull request as ready for review July 4, 2024 13:36
@stefanprodan stefanprodan added the area/oci OCI related issues and pull requests label Jul 11, 2024
@matheuscscp matheuscscp changed the title Add support for .spec.proxySecretRef for OCIRepository API Add proxy support for OCIRepository API Jul 11, 2024
stefanprodan
stefanprodan approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

darkowlzz
darkowlzz reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall implementation looks good to me.
Suggested a test with goproxy against the test registry.

internal/controller/ocirepository_controller.go Outdated Show resolved Hide resolved
internal/controller/ocirepository_controller.go Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the ocirepo-proxy branch 2 times, most recently from 1020bbb to ddc34c8 Compare July 17, 2024 10:21
@darkowlzz darkowlzz mentioned this pull request Jul 31, 2024
Closed
@matheuscscp matheuscscp force-pushed the ocirepo-proxy branch 5 times, most recently from 75e2c4f to 1b44a2c Compare August 12, 2024 15:22
darkowlzz
darkowlzz reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the proxy tests in OCI artifact verification. The notation related changes also look nice and minimal.
Left a few suggestions in the tests and docs. Everything else looks good to me.

internal/controller/ocirepository_controller_test.go Outdated Show resolved Hide resolved
internal/oci/notation/notation_test.go Outdated Show resolved Hide resolved
internal/oci/notation/notation_test.go Outdated Show resolved Hide resolved
docs/spec/v1beta2/ocirepositories.md Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the ocirepo-proxy branch 2 times, most recently from 0f905bb to a99476f Compare August 13, 2024 22:56
darkowlzz
darkowlzz reviewed Aug 14, 2024
View reviewed changes
tests/registry/registry.go Show resolved Hide resolved
tests/registry/registry.go Outdated Show resolved Hide resolved
internal/oci/notation/notation.go Outdated Show resolved Hide resolved
@matheuscscp matheuscscp force-pushed the ocirepo-proxy branch 2 times, most recently from a503050 to c9b27e1 Compare August 15, 2024 13:08
darkowlzz
darkowlzz approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for all the work on it.

@matheuscscp matheuscscp merged commit 7c4fdd5 into fluxcd:main Aug 15, 2024
9 checks passed
@matheuscscp matheuscscp deleted the ocirepo-proxy branch August 15, 2024 14:11
@stefanprodan stefanprodan mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
area/oci OCI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying HTTP/S proxy in OCIRepository API
3 participants
@matheuscscp @darkowlzz @stefanprodan