Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP provider for bucket source #809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Jul 1, 2022

Roughly address #808 to hook up with generic HTTP endpoints as sources to downstream components


tarReader := tar.NewReader(tarArchive)
for {
hdr, err := tarReader.Next()

Check failure

Code scanning / CodeQL

Arbitrary file write during zip extraction ("zip slip")

Unsanitized archive entry, which may contain '..', is used in a [file system operation](1). Unsanitized archive entry, which may contain '..', is used in a [file system operation](2). Unsanitized archive entry, which may contain '..', is used in a [file system operation](3). Unsanitized archive entry, which may contain '..', is used in a [file system operation](4).
Comment on lines +480 to +485
for _, f := range r.File {
err := extractAndWriteFile(f)
if err != nil {
return err
}
}

Check failure

Code scanning / CodeQL

Arbitrary file write during zip extraction ("zip slip")

Unsanitized archive entry, which may contain '..', is used in a [file system operation](1). Unsanitized archive entry, which may contain '..', is used in a [file system operation](2). Unsanitized archive entry, which may contain '..', is used in a [file system operation](3).
@stefanprodan stefanprodan added the invalid This doesn't seem right label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants