-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expire revisions on remote servers #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhnasa
force-pushed
the
issue-30-server-migration
branch
4 times, most recently
from
May 22, 2023 14:00
7db7b46
to
5353686
Compare
3 tasks
dhnasa
force-pushed
the
issue-30-server-migration
branch
3 times, most recently
from
June 26, 2023 00:16
fc5a31d
to
247e352
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
2 times, most recently
from
July 13, 2023 02:15
d82d828
to
705ca3d
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
from
October 9, 2023 22:47
705ca3d
to
8241928
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
4 times, most recently
from
October 19, 2023 18:54
66bef16
to
dc4fab5
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
from
November 6, 2023 13:42
dc4fab5
to
bd80eca
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
from
November 17, 2023 21:43
d1a4c51
to
bb1bcad
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
from
November 27, 2023 17:48
bb1bcad
to
eaf19de
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
2 times, most recently
from
December 8, 2023 14:59
2c3e6f2
to
f452ead
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
2 times, most recently
from
February 5, 2024 00:25
54cf114
to
6ab69ac
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
2 times, most recently
from
April 2, 2024 11:21
bb12f85
to
38594a6
Compare
ctheune
previously approved these changes
Apr 10, 2024
Not adding migrations for rev files as there was no release between the introduction of locations and this commit
The server with the largest number of local revisions is the leader. If the leader is offline another server will take over. This assumes that all servers share the same rng and thus schedule the backup at the same time. If this is not the case more backups than necessary may be created (but not less).
dhnasa
force-pushed
the
issue-30-server-migration
branch
2 times, most recently
from
April 11, 2024 12:00
e54e034
to
8538072
Compare
dhnasa
force-pushed
the
issue-30-server-migration
branch
from
April 11, 2024 13:06
8538072
to
6ccad75
Compare
ctheune
approved these changes
Apr 11, 2024
dhnasa
pushed a commit
that referenced
this pull request
Jun 12, 2024
This was already the case (due to a bug) for a long time, but was recently fixed in #37. This commit reintroduces this behaviour. The reasoning is that a backup which takes longer than 50% (grace period) of the configured interval indicates a problem with the backup server/network/etc...
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #62
closes #30, PL-131863
Support backup job migration across servers
Add
tags {set, add, remove}
subcommandAdd
expire
subcommandlogging: improve exception formatting
logging: add taskid
Add
push
andpull
subcommandAdd
server:
selector to revision specCoordinate backups for the same job between servers
The server with the largest number of local revisions is the leader.
If the leader is offline another server will take over.
This assumes that all servers share the same rng and thus
schedule the backup at the same time. If this is not the case more
backups than necessary may be created (but not less).
Security implications